feat: Add Sampling Decision to Trace Envelope Header#3286
Merged
Conversation
brustolin
requested review from
armcknight and
philipphofmann
as code owners
Contributor
|
Codecov Report
@@ Coverage Diff @@
## main #3286 +/- ##
=============================================
+ Coverage 89.169% 89.215% +0.045%
=============================================
Files 502 502
Lines 54263 54270 +7
Branches 19480 19488 +8
=============================================
+ Hits 48386 48417 +31
+ Misses 5016 4882 -134
- Partials 861 971 +110 Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 881a955 | 1254.14 ms | 1268.43 ms | 14.29 ms |
| 1bf8571 | 1250.96 ms | 1255.36 ms | 4.40 ms |
| 736495a | 1245.16 ms | 1254.42 ms | 9.26 ms |
| d257eb9 | 1206.98 ms | 1227.50 ms | 20.52 ms |
| effc81c | 1253.71 ms | 1256.16 ms | 2.45 ms |
| adca747 | 1199.37 ms | 1215.49 ms | 16.12 ms |
| a2af9fa | 1236.62 ms | 1253.12 ms | 16.50 ms |
| 90d17d3 | 1261.18 ms | 1278.18 ms | 17.00 ms |
| f8fc36d | 1226.31 ms | 1247.80 ms | 21.49 ms |
| 7cd187e | 1196.51 ms | 1226.04 ms | 29.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 881a955 | 22.85 KiB | 407.63 KiB | 384.79 KiB |
| 1bf8571 | 20.76 KiB | 437.12 KiB | 416.36 KiB |
| 736495a | 20.76 KiB | 435.22 KiB | 414.46 KiB |
| d257eb9 | 20.76 KiB | 433.22 KiB | 412.46 KiB |
| effc81c | 20.76 KiB | 433.18 KiB | 412.42 KiB |
| adca747 | 20.76 KiB | 401.36 KiB | 380.60 KiB |
| a2af9fa | 20.76 KiB | 432.87 KiB | 412.11 KiB |
| 90d17d3 | 20.76 KiB | 432.17 KiB | 411.41 KiB |
| f8fc36d | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| 7cd187e | 20.76 KiB | 401.66 KiB | 380.90 KiB |
Previous results on branch: feat/sampling-decision-trace-envelope
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b67b375 | 1242.42 ms | 1249.66 ms | 7.24 ms |
| a49138a | 1250.61 ms | 1261.72 ms | 11.11 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b67b375 | 22.85 KiB | 407.94 KiB | 385.09 KiB |
| a49138a | 22.85 KiB | 407.88 KiB | 385.03 KiB |
armcknight
approved these changes
Sep 18, 2023
Member
armcknight
left a comment
armcknight
left a comment
There was a problem hiding this comment.
Changes look fine. Though I wonder if an NSNumber encapsulating a boolean wouldn't be more appropriate than a string.
If we want to leave it as a string, we should consider using defined constants for the values.
brustolin
commented
Sep 19, 2023
armcknight
approved these changes
Sep 20, 2023
Member
armcknight
left a comment
armcknight
left a comment
There was a problem hiding this comment.
Updates look good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds
sampledflag to all trace envelope headers💡 Motivation and Context
closes #3201
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps